[5.6] Feature/add udiff methods to collection #23107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the methods are 1. udiff 2. diffUAssoc 3. diffUKeys
the methods are 1. udiff 2. diffUAssoc 3. diffUKeys
…samcrosoft/framework into feature/add-udiff-methods-to-collection
GrahamCampbell
changed the title
|
Can you come up with better names for the methods? We don't have to copy the underlying PHP function names. Something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Collection class of the Laravel has a diff method which uses the array_diff php function, sometimes this method isn't sufficient, especially when you need to defined a custom function to indicate different elements in collections.
A case in point is when you wish to do case insensitive difference of two collections. Thankfully, PHP has methods for cases such as this. I have implemented three of such method