Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Remove monologConfigurator infrastructure completely #23078

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

mfn
Copy link
Contributor

@mfn mfn commented Feb 8, 2018

This was made obsolete with the overhaul of the new logger in 5.6
and isn't applied anymore (i.e. dead code).

It was used in \Illuminate\Log\LogServiceProvider but is gone now (the removal happened in #22635 ).

Note

Applying this PR is a "hard break".

So far in 5.6 it's a "soft break", as in: even if you have used configureMonologUsing, it's not called anymore but you wouldn't notice until later. After merging this, anyone using it would immediately see a hard break in the application.

As I assume it's not coming back anymore, I additionally suggest to note this in the upgrade guide as a breaking change to 5.5

This was made obsolete with the overhaul of the new logger in 5.6
and isn't applied anymore (i.e. dead code).

It was used in `\Illuminate\Log\LogServiceProvider`
@taylorotwell taylorotwell merged commit b6f7cfb into laravel:5.6 Feb 8, 2018
@mfn mfn deleted the remove-configure-monolog branch February 8, 2018 18:48
@manoj-manoharan-backup-old
Copy link

manoj-manoharan-backup-old commented Jun 13, 2018

I need to configure S3 client adapter to logs, I'm currently using 5.5 and the configuration is working perfectly. Now how do i manually configure the logs to be written in S3 in 5.6.

`$app->configureMonologUsing(function ($monolog) use ($app) {

    $s3FileKey = \App\Helper\Util::getS3LogPath();

    $adapter = \Illuminate\Support\Facades\Storage::disk('s3')->getAdapter();
    $client = $adapter->getClient();
    $client->registerStreamWrapper();

    $s3Stream = "s3://{$adapter->getBucket()}/{$s3FileKey}";
    $streamHandler = (new \Monolog\Handler\StreamHandler($s3Stream));

    $monolog->pushHandler($streamHandler);
});`

Now how do i migrate this code to 5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants