[5.6] Keep same string format and avoid potential test failure #23056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, last PR #23047 sent to wrong branch.
ProcessUtils::escapeArgument
will return a string wrapped by single quote'artisan'
(on macOS, but other OS should have same issue), butartisan
is not wrapped. whenARTISAN_BINARY
is not defined, unit test will error.This PR make them in a same style.
Previous code could lead some potential test issue when running the test specifically in phpstorm targeting on one function
testMakeProcessCorrectlyFormatsCommandLine
intests/Queue/QueuePoolTest.php
. (might be a setup issue, but still should keep them in same style.)This could be seen as a breaking change so targeting 5.6 branch
Attached output dump with phpunit script