Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix inOrder assertions #23038

Merged
merged 2 commits into from
Feb 5, 2018

Conversation

mnabialek
Copy link
Contributor

This fixes @helmut #22915

In previous implementation when response contained foo bar foo and you ran:

$response->assertSeeInOrder(['foo', 'bar', 'foo']);

it failed and now it will pass.

Also tests updated a bit just to make sure both assertions fail as expected in tests.

@taylorotwell taylorotwell merged commit 09a1448 into laravel:5.6 Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants