Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Simplify testing database connection (sqlite) to use predefined connection "testing". #22855

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

crynobone
Copy link
Member

Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone changed the title Simplify sqlite to use predefined connection "testing". Simplify testing database connection (sqlite) to use predefined connection "testing". Jan 19, 2018
@GrahamCampbell GrahamCampbell changed the title Simplify testing database connection (sqlite) to use predefined connection "testing". [5.5] Simplify testing database connection (sqlite) to use predefined connection "testing". Jan 19, 2018
@taylorotwell taylorotwell merged commit 2ae6350 into laravel:5.6 Jan 19, 2018
taylorotwell added a commit that referenced this pull request Jan 19, 2018
taylorotwell added a commit that referenced this pull request Jan 19, 2018
@taylorotwell
Copy link
Member

Broke dozens of tests for me locally.

@crynobone
Copy link
Member Author

If it's broken then it's most likely env from phpunit.xml.dist not being used.

@crynobone
Copy link
Member Author

My best guess would be that you have phpunit.xml in your local install which would be preferred over phpunit.xml.dist which cause it to be broken.

@GrahamCampbell GrahamCampbell changed the title [5.5] Simplify testing database connection (sqlite) to use predefined connection "testing". [5.6] Simplify testing database connection (sqlite) to use predefined connection "testing". Jan 19, 2018
@crynobone crynobone deleted the testbench branch March 8, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants