[5.6] Fix pivot serialization #22786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k into fix-pivot-serialization
franzliedke
reviewed
Jan 14, 2018
|
|
||
| return $this->first() instanceof Pivot | ||
| ? $this->map->getQueueableId()->all() | ||
| : $this->modelKeys(); |
There was a problem hiding this comment.
What about adding getQueueableId() to the Model base class, and overriding it in Pivot? Then you can always map to getQueueableId() and get rid of the instanceof. 😉
DCzajkowski
reviewed
Jan 15, 2018
| /** | ||
| * Get the pivot columns for the relation. | ||
| * | ||
| * "pivot_" is prefixed ot each column for easy removal later. |
There was a problem hiding this comment.
Typo. "prefixed at", should be?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, passing a custom pivot model to a queued job will cause errors when pulling the job back off the queue. This correct the storage of pivot model and morphed pivot model queueable IDs and also adjusts the restoration queries to use the new format.