[5.5] Add stream download response

[TheoKouzelis]

Adds the ability to respond with remote files as downloads.

<?php

    Route::get('/', function () {
        return response()->streamDownload(function () {
            echo file_get_contents('https://my.remote.com/file/store-12345.jpg');
        }, 'nice-name.jpg');
    });

[mfn]

No tests?

[mfn]

string|null according to your method signature

[TheoKouzelis]

Hi @mfn

Thanks for the PR review. I have pretty much copied the doc block from the "download" method. Would you also like me to make the same change to that doc block as well?

[TheoKouzelis]

@mfn I couldn't find any tests for this class to add to. Do you know where a test for this method should go?

[sisve]

1. This looks very similar to the existing stream() method. Can't it be used for this purpose?
2. Should this new method be part of the ResponseFactory contract?

[TheoKouzelis]

Hi @sisve

Thanks for the PR review.

I was trying to copy the feel of the existing API of "file" and "download". Where file is just a basic wrapper around the Symfony class BinaryFileResponse and download goes one step further and sets up the content disposition. This PR was kind of born out of this stackoverflow question where it felt like people where searching for a similar function to download for remote files.

Good point about the ResponseFactory contract. I have missed that and I will get this added to this PR tonight.

[m1guelpf]

@TheoKouzelis If you are going to modify a contract, then you should target 5.6

[TheoKouzelis]

@m1guelpf OK cool thanks. Should I remove this PR and make a new branch of 5.6?

[mfn]

Yes, thanks!

[TheoKouzelis]

What is the discussion process behind adding a method to a contract? Because I'm looking at the ResponseFactory Contract in more detail and I can see "stream" and "download" are part of the interface but not "file". So it now makes me wonder if this method should be?

[TheoKouzelis]

This has now been moved to a PR on the 5.6 branch with @mfn doc block change and @sisve contract change added