-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.5] Clear user instance on rebind request #22649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it could change the credentials
+1 |
GrahamCampbell
changed the title
Clear user instance on rebind request
[5.5] Clear user instance on rebind request
Jan 5, 2018
Would this deserve a test to ensure it stays this way? |
BenCavens
pushed a commit
to BenCavens/framework
that referenced
this pull request
Jan 5, 2018
Because it could change the credentials
This commit breaks all my unit tests that use the // $this->user is a User instance
$this->actingAs($this->user, 'api');
$this
->get('/api/v2/user')
->assertStatus(200); The test passes when I revert this commit. |
This wrecks my tests. |
Wrecks my tests also @taylorotwell |
same here, all tests failed @taylorotwell |
Luckely there is a new PR to revert this: #22815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it could change the credentials