Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Clear user instance on rebind request #22649

Merged
merged 1 commit into from
Jan 5, 2018
Merged

[5.5] Clear user instance on rebind request #22649

merged 1 commit into from
Jan 5, 2018

Conversation

abler98
Copy link
Contributor

@abler98 abler98 commented Jan 5, 2018

Because it could change the credentials

Because it could change the credentials
@stremovskyy
Copy link

+1

@taylorotwell taylorotwell merged commit aa7b3a7 into laravel:5.5 Jan 5, 2018
@GrahamCampbell GrahamCampbell changed the title Clear user instance on rebind request [5.5] Clear user instance on rebind request Jan 5, 2018
@sisve
Copy link
Contributor

sisve commented Jan 5, 2018

Would this deserve a test to ensure it stays this way?

@abler98 abler98 deleted the patch-request-guard branch January 5, 2018 18:46
BenCavens pushed a commit to BenCavens/framework that referenced this pull request Jan 5, 2018
Because it could change the credentials
@timoschwarzer
Copy link
Contributor

timoschwarzer commented Jan 15, 2018

This commit breaks all my unit tests that use the actingAs helper.
I use Laravel Passport and a simple test like this fails.

// $this->user is a User instance
$this->actingAs($this->user, 'api');
$this
    ->get('/api/v2/user')
    ->assertStatus(200);

The test passes when I revert this commit.

@devcircus
Copy link
Contributor

This wrecks my tests.

@Thijmen
Copy link

Thijmen commented Jan 16, 2018

Wrecks my tests also @taylorotwell

@riseno
Copy link

riseno commented Jan 16, 2018

same here, all tests failed @taylorotwell

@Thijmen
Copy link

Thijmen commented Jan 16, 2018

Luckely there is a new PR to revert this: #22815

taylorotwell pushed a commit that referenced this pull request Jan 16, 2018
That commit caused unit tests using the actingAs helper to fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants