[5.5] Collection as parameter on Collection::except #22399

glorand · 2017-12-12T14:38:18Z

$collectionA = collect(['first' => 'First', 'last' => 'Last']);
$collectionB = collect(['first' => 'First']);
#Instead of 
$collectionC = $collectionA->except($collectionB->keys()->all());
#you can use in this way
$collectionC = $collectionA->except($collectionB);

taylorotwell · 2017-12-12T16:04:20Z

src/Illuminate/Support/Collection.php

     * @return static
     */
    public function except($keys)
    {
-        $keys = is_array($keys) ? $keys : func_get_args();
+        if ($keys instanceof Collection) {
+            $keys = $keys->keys()->items;


Isn't items protected?

yes, but it has direct access to it, I would suppose the method call would be better?

@lagbox all() method? probably yes

taylorotwell · 2018-01-16T13:44:19Z

Reverting this sense it doesn't make any sense and is a breaking change.

glorand added 2 commits December 12, 2017 16:33

Type collection as Collection::except parameter

22459dd

reformat

f2c915b

taylorotwell reviewed Dec 12, 2017

View reviewed changes

Use method to get the Collection items

2997ed3

GrahamCampbell changed the title ~~Collection as parameter on Collection::except~~ [5.5] Collection as parameter on Collection::except Dec 12, 2017

Update Collection.php

be46546

taylorotwell merged commit 18402a6 into laravel:5.5 Dec 13, 2017

amaelftah mentioned this pull request Jan 15, 2018

[5.5] Modify except collection method to have a single dimension collection #22802

Closed

glorand deleted the collection-except branch January 17, 2018 08:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.5] Collection as parameter on Collection::except #22399

[5.5] Collection as parameter on Collection::except #22399

glorand commented Dec 12, 2017

taylorotwell Dec 12, 2017

lagbox Dec 12, 2017 •

edited

Loading

glorand Dec 12, 2017

taylorotwell commented Jan 16, 2018 •

edited

Loading

[5.5] Collection as parameter on Collection::except #22399

[5.5] Collection as parameter on Collection::except #22399

Conversation

glorand commented Dec 12, 2017

taylorotwell Dec 12, 2017

Choose a reason for hiding this comment

lagbox Dec 12, 2017 • edited Loading

Choose a reason for hiding this comment

glorand Dec 12, 2017

Choose a reason for hiding this comment

taylorotwell commented Jan 16, 2018 • edited Loading

lagbox Dec 12, 2017 •

edited

Loading

taylorotwell commented Jan 16, 2018 •

edited

Loading