Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Revert "Operator optional (#22361)" #22370

Merged
merged 1 commit into from
Dec 9, 2017
Merged

[5.5] Revert "Operator optional (#22361)" #22370

merged 1 commit into from
Dec 9, 2017

Conversation

sisve
Copy link
Contributor

@sisve sisve commented Dec 9, 2017

This reverts commit 727b8f9, from #22361

These changes lacked tests, didn't change orWhereTime, and even more importantly, changed a method signature causing php warnings for those that have overridden it.

PHP Warning: Declaration of CustomBuilder::whereTime($column, $operator, $value, $boolean = 'and') should be compatible with Builder::whereTime($column, $operator, $value = NULL, $boolean = 'and')

@sisve sisve changed the title Revert "Operator optional (#22361)" [5.5] Revert "Operator optional (#22361)" Dec 9, 2017
@taylorotwell taylorotwell merged commit 8ea42ba into laravel:5.5 Dec 9, 2017
@sisve sisve deleted the revert-22361 branch December 9, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisve @taylorotwell