[5.5] Add operator support to Collection@partition #22352
Conversation
…/jasonvarga/framework into jasonvarga-feature/flysystem-cached-adapter
…laravel#22345) * Rollback to 7c8d3d0 Put the payload column of jobs table to the end of insert statements. * Rollback to 7c8d3d0 Put the payload column of jobs table to the end of insert statements. * Test: BuildDatabaseRecord returning 'payload' at the end (for 56ba5cc)
|
This is a breaking change |
|
@Dylan-DPC Dude, it is not... |
| { | ||
| $partitions = [new static, new static]; | ||
|
|
||
| $callback = $this->valueRetriever($callback); | ||
| $callback = func_num_args() == 1 |
There was a problem hiding this comment.
It will not make any difference in this case.
func_num_args() will always return an integer, no real need to typecheck in this case.
There was a problem hiding this comment.
Technically there's no difference indeed, just like 90% of other strict comparison cases out there. The difference here is we'll have an (arguably) better code standard.
|
Oh yeah it is not breaking. But having a parameter named "key" that takes in a callback as well is misleading |
|
Anyone that has derived from Collection and overridden the partition method will now see php warnings. I believe this indicates that the PR should target 5.6.
|
|
Looks good to me. Can you submit to master branch because of what @sisve noted. |
Enables this: