[5.5] Remove the between operator in basic where clause

[themsaid]

It's currently not working and generating wrong sql:

\App\User::where('created_at', 'between', ['2017-01-01', '2017-01-30'])->get();

Will generate

select * from users where created_at between 2017-01-01

[ntzm]

Should it not just be fixed?

[themsaid]

Like whereIn I believe whereBetween should be used instead.

[aleksandrlat]

In Illuminate\Database\Query\Builder::where something like

if ($operator == 'between') {
    return $this->whereBetween($column, $value, $boolean);
}

would be useful in case of array of wheres

Model::where([
    ['active', 1],
    ['created_at', 'between', ['2017-01-01', '2017-01-07']],
]);

I know I can use '<=', '>=' operators instead of 'between' in this case but still.

[themsaid]

@aleksandrlat I'm ok with both ways, @taylorotwell what do you think?

[taylorotwell]

I kind of agree people should just use whereBetween?

[JosephSilber]

@themsaid this broke my code. Took me a few hours to track it down 😢

I have a join with a BETWEEN where it checks if a given column's value is between two other columns:

$join->on('b.lft', 'BETWEEN', DB::raw('a.lft AND a.rgt'))

This is used to query a nested set table.

---

This used to generate:

join b on `b`.`lft` BETWEEN a.lft AND a.rgt

but now it generates:

join b on `b`.`lft` = `BETWEEN`

...which obviously leads to this error:

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'BETWEEN' in 'on clause'

---

I haven't touched this code in years, and it has worked flawlessly. This change broke it 😞

[AidasK]

Thanks for a breaking change in a stable version 👍