Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional check for loaded language file using json format #22165

Closed
wants to merge 3 commits into from
Closed

additional check for loaded language file using json format #22165

wants to merge 3 commits into from

Conversation

tweichart
Copy link

  • as the json file may contain invalid json this helps to ignore such files
  • just merges the language array when it's valid for the rest of the files
  • produced a php exception before, as the second parameter for array_merge was null due to invalid json in file

Tobias Weichart added 3 commits November 22, 2017 09:50
additional check for loaded language file using json format
9e959b0 
* as the json file may contain invalid json this helps to ignore such files
* just merges the language array when it's valid for the rest of the files
* produced a php exception before, as the second parameter for array_merge was null due to invalid json in file
fix for wong code styling
b67ec77 
* see details: https://styleci.io/analyses/8AglWk
fix for wong code styling
abd624f 
* see details: https://styleci.io/analyses/qxKpVN
@taylorotwell
Copy link
Member

Why ignore the files? We want to alert the developer of an error.

@tweichart tweichart mentioned this pull request Nov 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tweichart @taylorotwell