[5.6] Add test to expose bug on Collection::uniqueStrict()'s keyless calls #21860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
@taylorotwell, to make sure you get it: those are the tests related to the uniqueStrict bug, you may keep it closed, but someone would have to add those tests to SupportCollectionTest.php As for the chat between @GrahamCampbell and others about PR rules, I ended up splitting the PR in two, this one for the tests, the other one (merged) for the fix |
|
I didn't say please send another PR though, I was just explaining what the docs meant. :) |
|
Yeah, but that also meant I was not doing what the docs say I should be doing :P Also because it makes sense, tests (know the bugs) are far more important than having bugs fixed right away, it's not always easy to fix them, even when the fixing code is already written |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uniqueStrict()'s bug is being discussed here.