Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Default mail theme: Reset margins on th and td cells to fix Outlook propagation issue #21647

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

lupinitylabs
Copy link
Contributor

Using the mail::table component and the default Mail theme, table rows rendered in Outlook appear with a 30px top and bottom margin around them, making them >60 pixel high each.

This is due to the margin: 30px auto declaration in the .table table selector being propagated to both .table th and .table td selectors.

This can be fixed by resetting margins in both .table thand .table td selectors without negative side-effects in other mail clients.

The issue and the fix were both tested and confirmed in Outlook 2016.

Before:
outlook-before

After applying the fix:
outlook-after

I might add that there are lots more issues with the default template in Outlook 2016, as some margin declarations are blatantly ignored and would have to be replaced by paddings instead to show any effect. But this should probably be up for discussion in a different pull request.

@taylorotwell taylorotwell merged commit d13063b into laravel:5.5 Oct 13, 2017
@GrahamCampbell GrahamCampbell changed the title Default mail theme: Reset margins on th and td cells to fix Outlook propagation issue [5.5] Default mail theme: Reset margins on th and td cells to fix Outlook propagation issue Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants