[5.5] Blade: Make @json directive safe for use in HTML #21574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzliedke
referenced
this pull request
in flarum/framework
Oct 7, 2017
<\/script> tags in post content would sometimes be recognized as actually ending the script tag, even when escaped (not exactly sure why). This is fixed by encoding the < > characters in unicode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @ryantology here, the
@jsondirective should by default use encoding options that are safe to use in HTML output.We encountered a similar problem recently in Flarum that we fixed in a similar, albeit incomplete way. Once we upgrade to Laravel 5.5, we can then use the
@jsondirective.Technically, this is slightly breaking backwards-compatible, but doing so for the XSS-safety of the people, so I hope this is okay.
This also adds test and slightly prettifies the compiled output. :)