Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] make() signature in contract matches implementation #21553

Merged
merged 2 commits into from
Oct 6, 2017
Merged

[5.6] make() signature in contract matches implementation #21553

merged 2 commits into from
Oct 6, 2017

Conversation

Dylan-DPC-zz
Copy link

Contract function now matches implementation.

Discussion #21542

@Dylan-DPC-zz Dylan-DPC-zz changed the title [5.6] make method signature in contract matches implementation [5.6] make() signature in contract matches implementation Oct 5, 2017
@KKSzymanowski
Copy link
Contributor

I think, if we're going this way, why not do the same for the forever method for consistency:
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Contracts/Cookie/Factory.php#L21-L32
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Cookie/CookieJar.php#L72-L88

@taylorotwell taylorotwell merged commit 5ce5b6a into laravel:master Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKSzymanowski KKSzymanowski KKSzymanowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dylan-DPC-zz @KKSzymanowski @taylorotwell @Dylan-DPC