Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return hasher when value is null #21488

Closed
wants to merge 1 commit into from
Closed

return hasher when value is null #21488

wants to merge 1 commit into from

Conversation

browner12
Copy link
Contributor

this allows us to use the other methods on the Hasher (check, needsRehash).

similar to many of the other helper function that simply return the object if no value is passed.

@Dylan-DPC-zz
Copy link

Isn't this a breaking change?

@browner12
Copy link
Contributor Author

@Dylan-DPC and I discussed this in Slack. Found out that bcrypt(null) actually returns a hashed string, so this is technically a break.

Will close and retarget to master.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants