[5.5] Add make command for custom exceptions #21483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
I think this is maybe overkill? |
|
Why is that? I use custom exception a lot since the framework allows us to have the render method. I ended up duplicating an existing one or creating it manually, which I could do also with Controllers but we have a command for that. Sorry for bad english |
svenluijten
reviewed
Oct 2, 2017
| return $this->option('report') | ||
| ? __DIR__.'/stubs/exception-render-report.stub' | ||
| : __DIR__.'/stubs/exception-render.stub'; | ||
| } else { |
There was a problem hiding this comment.
You can get rid of this else, because it'll return early here.
There was a problem hiding this comment.
Yes, you're right, I was following the code in other MakeCommands. I'll fix it as soon as possible.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to create custom exceptions with
php artisan make:exception. This command will create the Exception inside the Exceptions namespace of the app.You can also use the flags
--renderand--reportto generate the methods.