[5.5] Add Tests Demonstrating and Fixes for Error on Retrieving a User By Token With a Bad Identifier #21368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2017
|
Looks good to me, thanks! |
|
How many more PRs do we need on this? 😬 |
|
Always at least one more. 😱 |
|
It's just getting really wearisome. We've gone through about 4-5 Laravel patch releases with this simple fix. |
|
I know. It's ridiculous. This one should end it. I've been throwing on tests with these last two pulls to block regressions from happening and continuing the insanity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue that @SebastianS90 pointed out and adds tests to demonstrate it.