Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Add driver parameter for new doctrine connection #21297

Merged
merged 1 commit into from
Sep 21, 2017
Merged

[5.5] Add driver parameter for new doctrine connection #21297

merged 1 commit into from
Sep 21, 2017

Conversation

CasperLaiTW
Copy link
Contributor

Fix sqlite create database missing driver parameter.

Reproduce:

.env

DB_CONNECTION=sqlite

Code

DB::getDoctrineConnection()->getSchemaManager()->createDatabase(database_path('database.sqlite'));

Error message:

PHP error:  Undefined index: driver in /vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/SqliteSchemaManager.php on line 54

Doctrine/DBAL/Schema/SqliteSchemaManager.php#L54

@CasperLaiTW
Add driver parameter for new doctrine connection
0cf3027 
Fix sqlite create database missing driver parameter.
@tillkruss tillkruss changed the title Add driver parameter for new doctrine connection [5.5] Add driver parameter for new doctrine connection Sep 20, 2017
@taylorotwell taylorotwell merged commit 0cf3027 into laravel:5.5 Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themsaid themsaid themsaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CasperLaiTW @themsaid @taylorotwell