[5.5] Restore Non Static Method Signature to Illuminate\Routing\Router::prepareResponse
#21114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
Illuminate\Routing\Router::prepareResponseIlluminate\Routing\Router::prepareResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request restores the non-static method signature of
Illuminate\Routing\Router::prepareResponseObjectfrom previous Laravel versions, adds a new static method namedIlluminate\Routing\Router::prepareResponseObject, and then replaces the one explicit static call toprepareResponsein the exception handler.Reason for this Request: I'm working with/at a company that has a PHP Extension (C code compiled into a
.sofile and loaded via aphp.inifile). The change in this method signature caused a host of problems that makes the.soextension unusable in Laravel 5.5 (happy to discuss these offline). We're working on a fix on our end, but it would be fantastic for our Laravel using customers if we could get the old method signature back.Also -- acknowledging that the time to bring this up was very likely before Laravel 5.5's release. I'm coming into this process late, but we're working hard on our regression tests so this doesn't happy again :) Thanks for the time/attention!