Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Removed optimize command #20771

Closed
wants to merge 1 commit into from
Closed

[5.5] Removed optimize command #20771

wants to merge 1 commit into from

Conversation

DCzajkowski
Copy link
Contributor

@DCzajkowski DCzajkowski commented Aug 26, 2017

Removed optimize command, since it was left empty anyway. Closes #20767

@DCzajkowski DCzajkowski changed the title Removed optimize command, since it was left empty anyway [5.5] Removed optimize command Aug 26, 2017
@sisve
Copy link
Contributor

sisve commented Aug 26, 2017

It is being deprecated for one release, according to laravel/ideas#383

@DCzajkowski
Copy link
Contributor Author

It is not a breaking change (since it won't destroy any codebase) and it isn't really deprecated. It is softly removed currently, which makes no sense whatsoever.

@taylorotwell
Copy link
Member

We'll remove it in 5.6 and note in the upgrade guide for 5.5. It can break deployment scripts that are calling it if we remove it without warning.

@DCzajkowski
Copy link
Contributor Author

What about making it write to the console?:

[Warning] Deprecated ...

@decadence
Copy link
Contributor

Can somebody explain why this was deprecated and what is alternative?

@timacdonald
Copy link
Member

@decadence i think I remember Taylor maybe saying on a podcast that due to performance improvements in PHP itself (OPCache and whatnot) the command didn't really have any benifit anymore. Don't quote me on that...

@decadence
Copy link
Contributor

@timacdonald thanks

@josegus
Copy link

josegus commented Sep 13, 2020

so.. should we still using config:cache, route: cache.. ?

@josegus
Copy link

josegus commented Sep 13, 2020

I've just created a new laravel 8.1 through laravel installer, and "artisan optimize" is in the command list

@me-shaon
Copy link
Contributor

me-shaon commented Feb 1, 2021

@josegus The optimize command was again added later through this PR: #23468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants