[5.4] Fix JoinClause's whereIn when using a subquery #20453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
You should be able to pass an existing Builder to
whereIn
of aJoinClause
, but this doesn't work because theif ($values instanceof static)
doesn't catch the expected case when you pass aBuilder
because it's not an instance ofJoinClause
.TypeError: Argument 1 passed to Illuminate\Database\Grammar::parameterize() must be of the type array, object given
Steps To Reproduce: