[5.5] Add a str_hash() helper #20169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typically we would include the method on the Str class as well. |
|
@taylorotwell Should I move the app() method to the Str class or use the Hash facade? |
|
Really seems out-of-place in string helpers. Maybe the "str_" prefix isn't the best naming choice for bcrypt replacement. |
|
Yeah @taylorotwell I agree witj @devcircus |
|
I'm not sure this is even needed to be honest. Just use Hash::make(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new helper that will replace
bcrypt()in the future, as requested by Taylor in my last PR.@taylorotwell Should I also deprecate (adding a
@deprecateddocblock & triggering a deprecated error)bcrypt()or are we leaving this for another Laravel release?