[5.5] Add Collection::wrap method #20055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonShar
reviewed
Jul 14, 2017
| public static function wrap($value) | ||
| { | ||
| return $value instanceof self | ||
| ? new static($value->all()) |
There was a problem hiding this comment.
any reason not to just return $value here?
There was a problem hiding this comment.
Nope. getArrayableItems correctly deals with this case. Updating…
If the given value is not a collection, wrap it in one. If you pass a collection or an array as the value you get a collection with data in the collection or array back. If you pass in anything else you get a collection of one containing that value.
thecrypticace
force-pushed
the
feature/collection-wrap
branch
from
67e46a2 to
f37f38e
Compare
|
I guess I'll merge this because people will just keep sending it. 😬 |
|
Haha Taylor can be brute forced :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the given value is not a collection, wrap it in one. This is the collection equivalent to
Arr::wrap.If you pass a collection or an array as the value you get a collection with data in the collection or array back. If you pass in anything else you get a collection of one containing that value.
Had the idea while reading the code for PR #20053. It could turn 7 LoC (at the end of
setInverseRelation) in that PR to this:Collection::wrap($models)->each->setRelation($this->inverseSide, $parent);No more pesky instanceof check! and it reads rather well too.