[5.5] Fix conflicts on ModelMakeCommand #19939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've renamed the shortcut for the factory, otherwise it would throw an error saying that 2 shortcuts with the same name exist.
|
was this a 5.5 only thing? didn't notice it on 5.4 |
|
The conflict was introduced here. |
|
That was the first thing that crossed my mind when I saw that pr submitted. Didn't have time to check the code though. |
Closed
|
is it just me or there's still a problem with this file ?https://github.com/laravel/framework/blob/master/src/Illuminate/Foundation/Console/ModelMakeCommand.php how can it pass CI ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've renamed the shortcut for the factory, otherwise it would throw an error saying that 2 shortcuts with the same name exist.