[5.5] Add a "validated" method to the form request #19112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSilber
force-pushed
the
form-request-validated
branch
from
92e5e25 to
86beb6b
Compare
JosephSilber
force-pushed
the
form-request-validated
branch
from
86beb6b to
e9a28ac
Compare
|
Can we name the method |
JosephSilber
force-pushed
the
form-request-validated
branch
from
e9a28ac to
81f3426
Compare
JosephSilber
changed the title
JosephSilber
force-pushed
the
form-request-validated
branch
from
81f3426 to
eb02670
Compare
rodrigopedra
reviewed
May 9, 2017
| */ | ||
| public function validated() | ||
| { | ||
| return $this->only(array_keys($this->container->call([$this, 'rules']))); |
There was a problem hiding this comment.
@JosephSilber why not calling $this->rules() directly as the object is already instantiated?
There was a problem hiding this comment.
@rodrigopedra $this->container->call([$this, 'rules']) calls the method and inject any dependencies it has declared, as method parantheses. $this->rules() doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would allow you to only get the validated input from the request: