Strict comparison for returning scope results on query builder. #18842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be sent to 5.5 (master branch) since it's a breaking change. |
|
Sure thing, what is the minimum required PHP version for Laravel 5.5? EDIT: All good, found it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the
callScope()function is implemented is to return the query builder onnull,0, orfalse(loose comparison) for the result.This change will have the
callScope()method on the query builder only return$thisif the$resultisnullonly.In my application, I created a query scope that performs the query, evaluates the results and returns a boolean. I was expecting false when a query builder was returned.