[5.4] Add assertSuccessful(), tweak assertRedirect() #18629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
assertSuccessful()which is similar to a helper that existed back in Laravel 5.3 and also makes a slight tweak to the functionality ofassertRedirect()so it can be used more loosely.assertSuccessful()just asserts that the status code is2xx, which is handy when you don't really care if the response isOK,Created,No Contentetc.assertRedirect()'s argument is now optional, and by calling it without an argument you simply assert that the response is a redirect, making no assertion on where it actually redirects to.