[5.4] Added exception error when bootstrap/cache directory is not writable #18188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdabby
force-pushed
the
bootstrap_cache_exception
branch
2 times, most recently
from
e9238a2 to
128ab51
Compare
GrahamCampbell
changed the title
|
Doesn't have to be writable tbh. It is possible to use laravel without this requirement. |
|
I believe you're right in some cases, but by the time it reaches this point, it is preparing to write and will fail if it can't. |
|
This probably shouldn't emit a I realize it includes a message about what's really happening but FileNotFound is very specific and this isn't dealing with a file not able to be found. |
|
Is there such an exception? |
There doesn't need to be. We just make our own class. :P |
| @@ -180,9 +181,14 @@ protected function freshManifest(array $providers) | |||
| * | |||
| * @param array $manifest | |||
| * @return array | |||
| * @throws FileNotFoundException | |||
There was a problem hiding this comment.
Please follow our code style here. See the other phpdoc for reference. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an annoying issue related to: #17969 where a generic error is thrown if the bootstrap/cache directory is not present or writable.