Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] test: MysqlJoinDeleteWithAlias #18098

Closed
wants to merge 1 commit into from

Conversation

puggan
Copy link

@puggan puggan commented Feb 24, 2017

Unit test for bug: invalid sql when join and alias are used in delete-queries.

Exemple code:

DB::table('join_test AS a')->join('join_test AS b', 'a.id', '<', 'b.id')->delete();

Should create a query like:
DELETE a FROM join_test AS a...

Currently creates a query like:
DELETE join_test AS a FROM join_test AS a

This unit test checks that the original table name isn't included before the FROM when join and alias are used.

@GrahamCampbell GrahamCampbell changed the title test: MysqlJoinDeleteWithAlias [5.3] test: MysqlJoinDeleteWithAlias Feb 27, 2017
@taylorotwell
Copy link
Member

@themsaid can you look at getting a fix for this in 5.4?

@themsaid
Copy link
Member

sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants