[5.4] Now sets the connection property of the Migration object #17549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landsem
changed the title
|
Fixes issue #17546 if the migration is written to use the connection that is in the connection property of the Migrate object |
|
Is this fixed by #17574? |
|
Yes, #17574 fixed it. |
|
Well, partially. The Migration is now run on the database specified in the |
|
Did this ever get merged into 5.4? I see the pull request, but when I look at the master branch, I don't see where it's been merged. I installed a fresh copy of 5.4, and these changes aren't in there either. I'm also running into issues where I can't set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration object did not have a setter for the connection property, and the property
was not being set by the MigrateCommand.