[5.3] Fix detach behaviour (BelongsToMany.php) #16144
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change behaviour of detach.
Actual behaviour is: If it receives an empty array or collection it will erase all associations.
Example:
$houses = App\Houses::where("windows",3)->get();
//returns empty collection$investor->houses()->detach($houses);
//detaches all houses from $investorThe code above will detach all houses if $houses returns empty.
New behaviour: if it does not receive arguments, all associations are removed. If there is an argument and it is empty, no associations will be broken.
$houses = App\Houses::where("windows",3)->get();
//returns empty collection$investor->houses()->detach($houses);
//detaches nothingCode modification checks if any $id argument was given and if it's empty, returns zero, to indicate nothing was detached.