[5.4] Cache fix 15578 #15831
Merged
[5.4] Cache fix 15578 #15831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert the change to the gitignore and squash to one commit. |
Change flush return type If a flush operation fails, then you now have chance of knowing about it. Change flush method, return false on failure Change flush test Ensuring that flush method does return false, should the delete directories return false. Change wrapper flush return type Both apcu_clear_cache() and apc_clear_cache() return bool values, which can indicate if flush operation fails. Change flush method, return bool Add Apc flush test Change flush method return type Change flush test, check return of flush method Change flush method return type The table delete() returns the number of affected rows. If the number is higher that zero, then the operation has succeeded. If not, it means that there was nothing to delete... Not too sure about this one, however, it should be the most correct response, if you do expect something to be deleted and zero is returned. Change flush test, check flush return Change flush method return type Memcached's flush method also returns true. Add flush test Change flush method return type Change flush method return type Not sure about flushdb() return. However, from what I understand, it never fails and thus should return something like "ok" back. Add flush test Add release note about cache flush change Revert "Ignore PHPStorm IDE file" This reverts commit 8176c32.
aedart
force-pushed
the
cache-fix-15578
branch
from
98a447a to
4543caa
Compare
|
Done - sorry about the "stupid" commit message. Used an IDE and pressed a bit too quickly though the wizard. |
|
You don't need to update the change log manually. Please remove that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are made, however, I'm not too sure about all the store's underlying implementation. Therefore, I would really appreciate your eyes on those changes and the tests that I have changed or added.
Also, because this is a change in the interface, I presumed that these change will not make it into the 5.3 series.