[5.3] Change read to timestamp from boolean #14797
Conversation
GrahamCampbell
changed the title
|
Im unsure if this should be |
| @@ -52,7 +53,7 @@ public function notifiable() | |||
| */ | |||
| public function markAsRead() | |||
| { | |||
| $this->forceFill(['read' => true])->save(); | |||
| $this->forceFill(['read' => Carbon::now()])->save(); | |||
There was a problem hiding this comment.
Just a thought, could do $this->freshTimestamp() here instead - would give you a new Carbon instance and save needing to add the use statement.
There was a problem hiding this comment.
I've never used that before.
Is it done like this:
$this->forceFill(['read' => $this->freshTimestamp()])->save();
There was a problem hiding this comment.
Yeah - that's the one!
|
Maybe it should be named |
|
+1 for |
|
Could you send PR to docs when you get a chance. Thanks! |
|
@taylor I have documented this on the docs branch, but there is a merge conflict, so feel free to take the deltas and just apply them yourself :) |
* Change read to timestamp from boolean * Use timestamps not datetime * Dont use carbon, instead use freshTimstamp() * Use read_at not read
No description provided.