Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the return error of value's type #14776

Closed
wants to merge 1 commit into from
Closed

fix the return error of value's type #14776

wants to merge 1 commit into from

Conversation

ganxiangdong
Copy link

No description provided.

@GrahamCampbell
Copy link
Member

This function may return either an integer or a float as described in the phpdoc.

@ganxiangdong
Copy link
Author

those functions return type is string now

@GrahamCampbell
Copy link
Member

Oh, do they! That looks like a mistake.

@GrahamCampbell
Copy link
Member

The aggregate function is marked as only floats and integers, so I guess we need a proper fix there.

@GrahamCampbell
Copy link
Member

Ok, I've provided a fix: #14781.

@GrahamCampbell
Copy link
Member

This has been reverted. These functions support max dates which are strings. Our doc is just wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganxiangdong @GrahamCampbell