Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Single middleware pipeline #14097

Merged
merged 2 commits into from
Jun 22, 2016
Merged

[5.3] Single middleware pipeline #14097

merged 2 commits into from
Jun 22, 2016

Conversation

JosephSilber
Copy link
Member

@JosephSilber JosephSilber commented Jun 22, 2016 •
edited
Loading

  1. Removes a lot of code duplication.
  2. Properly sorts all middleware according to priority.
  3. Controller middleware now all properly fire terminate.

@JosephSilber JosephSilber force-pushed the single-middleware-pipeline branch 2 times, most recently from 8354bca to 144593e Compare June 22, 2016 02:37
@JosephSilber JosephSilber force-pushed the single-middleware-pipeline branch from 144593e to ce0d33d Compare June 22, 2016 02:38
@taylorotwell taylorotwell merged commit ce0d33d into laravel:5.3 Jun 22, 2016
@JosephSilber JosephSilber deleted the single-middleware-pipeline branch June 22, 2016 13:39
crynobone
crynobone reviewed Jun 22, 2016
View reviewed changes
src/Illuminate/Routing/ControllerDispatcher.php
*
* @var \Illuminate\Container\Container
*/
protected $container;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/laravel/framework/blob/5.3/src/Illuminate/Routing/RouteDependencyResolverTrait.php#L85

RouteDependencyResolverTrait is using $container from ControllerDispatcher.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2016-06-22 at 10 11 20 pm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @JosephSilber

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here: #14108

@tomschlick tomschlick mentioned this pull request Aug 15, 2016
Closed
@fernandobandeira fernandobandeira mentioned this pull request Aug 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JosephSilber @crynobone @taylorotwell