[5.2] Add loadOnly() method to only load specified relations #14090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #14031
Say we have three Models
User
,UserData
andUserComments
.User
has auserData
relationship that we always want to eager load, so we define that in the$with
attribute. It also has auserComments
relationship that we eager load as required.Now, consider this...
This will eager load the specified
userComments
relationship AND also load theuserData
relationship. This is perhaps a little confusing, because that is not what we wanted to do.Not sure if this is expected behaviour, or an oversight in the behaviour of the
load()
method...current behaviour seems counter intuitive.To maintain backwards compatibility, I suggest a new method called
loadOnly()
, which will actually load ONLY the specified relationships.