Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Container minor change #13757

Merged
merged 1 commit into from
May 29, 2016
Merged

[5.2] Container minor change #13757

merged 1 commit into from
May 29, 2016

Conversation

KennedyTedesco
Copy link
Contributor

Just simplifying.

@KennedyTedesco
[5.2] Container minor change
3c0ddd0 
Just simplifying.
@GrahamCampbell
Copy link
Member

I prefer the original one. It's much clearer.

@KennedyTedesco
Copy link
Contributor Author

Yeah, is a point of view. 😄 To me, the new one is clear enough because we are evaluating a string.

@taylorotwell taylorotwell merged commit 710ff13 into laravel:5.2 May 29, 2016
@KennedyTedesco KennedyTedesco deleted the container-5.2 branch May 29, 2016 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KennedyTedesco @GrahamCampbell @taylorotwell