Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix issue #12628 Scheduler no longer runs commands in background #13557

Merged
merged 1 commit into from
May 16, 2016

Conversation

jn-jairo
Copy link
Contributor

Fix issue #12628

The fix adds a option runInBackground, so for long tasks just need add runInBackground() like the example:

$schedule->command("email:customers")->runInBackground()->withoutOverlapping();
$schedule->command("email:organisations")->runInBackground()->withoutOverlapping();
$schedule->command("email:administrators")->runInBackground()->withoutOverlapping();

@jn-jairo jn-jairo changed the title Fix issue #12628 Scheduler no longer runs commands in background [5.2] Fix issue #12628 Scheduler no longer runs commands in background May 15, 2016
@taylorotwell
Copy link
Member

How exactly is this running them in the background?

@GrahamCampbell
Copy link
Member

@taylorotwell See 9147bf7. In particular, read the full commit message. This PR reverts that change.

@taylorotwell
Copy link
Member

But using Symfony process doesn't run commands in the background necessarily.

@taylorotwell taylorotwell merged commit d6b581d into laravel:5.2 May 16, 2016
@taylorotwell
Copy link
Member

Looks like this method doesn't trim off the &

@jn-jairo jn-jairo deleted the fix-issue-12628 branch May 16, 2016 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants