[5.2] Add "Generated Columns" support to MySQL schema grammar #13430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param \Illuminate\Database\Schema\Blueprint $blueprint | ||
| * @param \Illuminate\Support\Fluent $column | ||
| * @return string|null |
There was a problem hiding this comment.
I think this should be string|void
There was a problem hiding this comment.
void cannot be unioned with anything
There was a problem hiding this comment.
Could you elaborate on that ? References ?
There was a problem hiding this comment.
laravel considers void to mean garbage, not "no return"
There was a problem hiding this comment.
it is possible that definition is changing in php 7.1, but for now, we're sticking with our original definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates Virtual and Stored generated columns introduced in MySQL 5.7.6.
For Reference:
http://dev.mysql.com/doc/refman/5.7/en/create-table-generated-columns.html