[5.2] Make MessageBag constructor consistent with add method #13196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the behaviour between initialising a new
MessageBag
and using theadd
method is inconsistent.The
add
method tests for uniqueness (of the key, and the message in the keyed bag), whereas the constructor will accept duplicate messages.I'm not certain if this is on purpose, so I have opened a PR with a failing test to demonstrate the proposed behaviour, which will amend should the desire exist to match the behaviour between the constructor and public API of the MessageBag class.
It appears this has been around since January, 2013, so this would likely be targeted to next release due to backwards compatibility breakage.