Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Refresh remember_token if reset password #13016

Merged
merged 1 commit into from
Apr 5, 2016
Merged

[5.2] Refresh remember_token if reset password #13016

merged 1 commit into from
Apr 5, 2016

Conversation

apollopy
Copy link
Contributor

@apollopy apollopy commented Apr 4, 2016

For security reasons, if the user to reset the password, refresh remember_token.

because:

In this case the user may have been hacking account

All the old password generated remember cookie should not be trusted

#13012

For security reasons, if the user to reset the password, refresh remember_token.
@apollopy
Copy link
Contributor Author

apollopy commented Apr 4, 2016

In fact, I think, at this time, the old session should also be invalid

But to do so, the user database must add new field session_token, if change or reset passwords, change session_token

session recording user_id | session_token to validate, not only recording user_id

If the development team considered feasible, I will continue coding

@apollopy apollopy changed the title Refresh remember_token if reset password [5.2] Refresh remember_token if reset password Apr 4, 2016
@taylorotwell taylorotwell merged commit b972334 into laravel:5.2 Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants