Laravel migrate postgres comment() don't work

[HaroldV]

• Laravel Version: 5.4
• PHP Version: 7.0
• Database Driver & Version: Postgresql

Description:

Do not work function comment in the migration with postgresql

Steps To Reproduce:

this is in the migrate = $table->string('name',35)->nullable(false)->comment('Status Name');
I execute migrate and nothing

[Dylan-DPC-zz]

@HaroldV steps to reproduce?

[HaroldV]

this is in the migrate = $table->string('name',35)->nullable(false)->comment('Status Name');
I execute migrate and nothing

[andrey-helldar]

Maybe, There is no COMMENT command in the SQL standard.
https://www.postgresql.org/docs/9.5/static/sql-comment.html

[garbinmarcelo]

Did you find any solution?

[HaroldV]

no marcelogarbin :(

[ghunti]

I have the same issue.
For now I'm issuing a new command just for the comment: DB::select("COMMENT ON COLUMN table_name.column_name IS 'the comment'");

[diegorm221]

I made a project with the versions that you wrote, i think is a problem with your postgres version, test with 9.4 version or later.
I made in the migration:
public function up()
{
Schema::create('table_name', function (Blueprint $table) {
$table-> string('name', 35)->nullable(false)->comment('Status Name');
});
}

[ghunti]

@Diego0037 The command you wrote creates the column but it doesn't create the comment. Did you check if you have the comment on that column with a postgresl client?? Looking at Laravel source code I don't think it supports comments for Postgresql but I might be wrong.
I'm using Postgres 9.6 and I had to do the manual comment with a DB::statement.

[vaughany]

I can confirm that in Postgres 9.5.7, the following snippet creates a char column but without a comment:

$table->char('char')->default('some default')->comment('this is a comment');

\d+ test command in psql:

Column  |      Type      |                 Modifiers                 | Storage  | Stats target | Description 
--------+----------------+-------------------------------------------+----------+--------------+-------------
char    | character(255) | not null default 'some default'::bpchar   | extended |              | 

[bardrotzer]

I'm not sure how to implement this, but looking at the documentation for postgres it implements a different syntax for adding comments. As of today only MySql comments are supported for Laravel.

Something along this line would be needed to get comments working in PostgresGrammar.php

    protected function modifyComment(Blueprint $blueprint, Fluent $column)
    {
        if (! is_null($column->comment)) {
            return " COMMENT ON COLUMN ". getColumnNameMethod()." '".addslashes($column->comment)."';"
        }
    }

I have not tested this as I am quite new with laravel. Just to be clear, there is no getcolumnNameMethod just to highlight that we need some way of getting the "my_table.my_column" values

Any ideas if this may work?

[mfn]

I believe this issue can be closed; the references PR implements this for postgres.