[5.6] Revert PR that breaks shuffling collection with seed + tests (#…

…22813) * Revert #22807 * Add tests for shuffling collection with seed * Fix CS
laravel · Jan 16, 2018 · cf4a385 · cf4a385
1 parent c1e1884
commit cf4a385
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Illuminate/Support/Collection.php b/src/Illuminate/Support/Collection.php
@@ -1309,7 +1309,7 @@ public function shuffle($seed = null)
             srand($seed);
 
             usort($items, function () {
-                return random_int(-1, 1);
+                return rand(-1, 1);
             });
         }
 

diff --git a/tests/Support/SupportCollectionTest.php b/tests/Support/SupportCollectionTest.php
@@ -143,6 +143,16 @@ public function testCollectionIsConstructed()
         $this->assertEmpty($collection->all());
     }
 
+    public function testCollectionShuffleWithSeed()
+    {
+        $collection = new Collection((range(0, 100, 10)));
+
+        $firstRandom = $collection->shuffle(1234);
+        $secondRandom = $collection->shuffle(1234);
+
+        $this->assertEquals($firstRandom, $secondRandom);
+    }
+
     public function testGetArrayableItems()
     {
         $collection = new Collection;