[5.6] Parameter has no usage inside the method. So we better remove i…

…t. (#22202)

*  parameter has no usage inside the method. So we better remove it.

* Clearing third decayMinutes parameter form everywhere of tooManyAttempts method call

src/Illuminate/Cache/RateLimiter.php

@@ -32,10 +32,9 @@ public function __construct(Cache $cache)
      *
      * @param  string  $key
      * @param  int  $maxAttempts
-     * @param  float|int  $decayMinutes
      * @return bool
      */
-    public function tooManyAttempts($key, $maxAttempts, $decayMinutes = 1)
+    public function tooManyAttempts($key, $maxAttempts)
     {
         if ($this->attempts($key) >= $maxAttempts) {
             if ($this->cache->has($key.':timer')) {

src/Illuminate/Foundation/Auth/ThrottlesLogins.php

@@ -20,7 +20,7 @@ trait ThrottlesLogins
     protected function hasTooManyLoginAttempts(Request $request)
     {
         return $this->limiter()->tooManyAttempts(
-            $this->throttleKey($request), $this->maxAttempts(), $this->decayMinutes()
+            $this->throttleKey($request), $this->maxAttempts()
         );
     }
 

src/Illuminate/Routing/Middleware/ThrottleRequests.php

@@ -48,7 +48,7 @@ public function handle($request, Closure $next, $maxAttempts = 60, $decayMinutes
 
         $maxAttempts = $this->resolveMaxAttempts($request, $maxAttempts);
 
-        if ($this->limiter->tooManyAttempts($key, $maxAttempts, $decayMinutes)) {
+        if ($this->limiter->tooManyAttempts($key, $maxAttempts)) {
             throw $this->buildException($key, $maxAttempts);
         }
 

tests/Cache/CacheRateLimiterTest.php

@@ -22,7 +22,7 @@ public function testTooManyAttemptsReturnTrueIfAlreadyLockedOut()
         $cache->shouldReceive('add')->never();
         $rateLimiter = new RateLimiter($cache);
 
-        $this->assertTrue($rateLimiter->tooManyAttempts('key', 1, 1));
+        $this->assertTrue($rateLimiter->tooManyAttempts('key', 1));
     }
 
     public function testHitProperlyIncrementsAttemptCount()