unify exception formatting (#23266)

src/Illuminate/Database/Connectors/ConnectionFactory.php

@@ -283,6 +283,6 @@ protected function createConnection($driver, $connection, $database, $prefix = '
                 return new SqlServerConnection($connection, $database, $prefix, $config);
         }
 
-        throw new InvalidArgumentException("Unsupported driver [$driver]");
+        throw new InvalidArgumentException("Unsupported driver [{$driver}]");
     }
 }

src/Illuminate/Database/DatabaseManager.php

@@ -137,7 +137,7 @@ protected function configuration($name)
         $connections = $this->app['config']['database.connections'];
 
         if (is_null($config = Arr::get($connections, $name))) {
-            throw new InvalidArgumentException("Database [$name] not configured.");
+            throw new InvalidArgumentException("Database [{$name}] not configured.");
         }
 
         return $config;

src/Illuminate/Database/Eloquent/Builder.php

@@ -1308,9 +1308,9 @@ public static function __callStatic($method, $parameters)
         }
 
         if (! isset(static::$macros[$method])) {
-            $class = static::class;
-
-            throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+            throw new BadMethodCallException(sprintf(
+                'Method %s::%s does not exist.', static::class, $method
+            ));
         }
 
         if (static::$macros[$method] instanceof Closure) {

src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php

@@ -411,7 +411,9 @@ protected function getRelationshipFromMethod($method)
         $relation = $this->$method();
 
         if (! $relation instanceof Relation) {
-            throw new LogicException(get_class($this).'::'.$method.' must return a relationship instance.');
+            throw new LogicException(sprintf(
+                '%s::%s must return a relationship instance.', static::class, $method
+            ));
         }
 
         return tap($relation->getResults(), function ($results) use ($method) {

src/Illuminate/Database/Query/Builder.php

@@ -2519,8 +2519,8 @@ public function __call($method, $parameters)
             return $this->dynamicWhere($method, $parameters);
         }
 
-        $class = static::class;
-
-        throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+        throw new BadMethodCallException(sprintf(
+            'Method %s::%s does not exist.', static::class, $method
+        ));
     }
 }

src/Illuminate/Database/Query/JsonExpression.php

@@ -40,6 +40,6 @@ protected function getJsonBindingParameter($value)
                 return '?';
         }
 
-        throw new InvalidArgumentException('JSON value is of illegal type: '.$type);
+        throw new InvalidArgumentException("JSON value is of illegal type: {$type}");
     }
 }

src/Illuminate/Filesystem/FilesystemAdapter.php

@@ -665,7 +665,7 @@ protected function parseVisibility($visibility)
                 return AdapterInterface::VISIBILITY_PRIVATE;
         }
 
-        throw new InvalidArgumentException('Unknown visibility: '.$visibility);
+        throw new InvalidArgumentException("Unknown visibility: {$visibility}");
     }
 
     /**

src/Illuminate/Http/RedirectResponse.php

@@ -231,8 +231,8 @@ public function __call($method, $parameters)
             return $this->with(Str::snake(substr($method, 4)), $parameters[0]);
         }
 
-        $class = static::class;
-
-        throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+        throw new BadMethodCallException(sprintf(
+            'Method %s::%s does not exist.', static::class, $method
+        ));
     }
 }

src/Illuminate/Mail/Mailable.php

@@ -746,8 +746,8 @@ public function __call($method, $parameters)
             return $this->with(Str::snake(substr($method, 4)), $parameters[0]);
         }
 
-        $class = static::class;
-
-        throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+        throw new BadMethodCallException(sprintf(
+            'Method %s::%s does not exist.', static::class, $method
+        ));
     }
 }

src/Illuminate/Notifications/Channels/BroadcastChannel.php

@@ -70,8 +70,6 @@ protected function getData($notifiable, Notification $notification)
             return $notification->toArray($notifiable);
         }
 
-        throw new RuntimeException(
-            'Notification is missing toArray method.'
-        );
+        throw new RuntimeException('Notification is missing toArray method.');
     }
 }

src/Illuminate/Notifications/Channels/DatabaseChannel.php

@@ -44,8 +44,6 @@ protected function getData($notifiable, Notification $notification)
             return $notification->toArray($notifiable);
         }
 
-        throw new RuntimeException(
-            'Notification is missing toDatabase / toArray method.'
-        );
+        throw new RuntimeException('Notification is missing toDatabase / toArray method.');
     }
 }

src/Illuminate/Redis/RedisManager.php

@@ -83,9 +83,7 @@ public function resolve($name = null)
             return $this->resolveCluster($name);
         }
 
-        throw new InvalidArgumentException(
-            "Redis connection [{$name}] not configured."
-        );
+        throw new InvalidArgumentException("Redis connection [{$name}] not configured.");
     }
 
     /**

src/Illuminate/Routing/Controller.php

@@ -65,8 +65,8 @@ public function callAction($method, $parameters)
      */
     public function __call($method, $parameters)
     {
-        $class = static::class;
-
-        throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+        throw new BadMethodCallException(sprintf(
+            'Method %s::%s does not exist.', static::class, $method
+        ));
     }
 }

src/Illuminate/Routing/Middleware/ThrottleRequests.php

@@ -99,9 +99,7 @@ protected function resolveRequestSignature($request)
             return sha1($route->getDomain().'|'.$request->ip());
         }
 
-        throw new RuntimeException(
-            'Unable to generate the request signature. Route unavailable.'
-        );
+        throw new RuntimeException('Unable to generate the request signature. Route unavailable.');
     }
 
     /**

src/Illuminate/Routing/RouteRegistrar.php

@@ -175,8 +175,8 @@ public function __call($method, $parameters)
             return $this->attribute($method, $parameters[0]);
         }
 
-        $class = static::class;
-
-        throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+        throw new BadMethodCallException(sprintf(
+            'Method %s::%s does not exist.', static::class, $method
+        ));
     }
 }

src/Illuminate/Support/Manager.php

@@ -57,7 +57,9 @@ public function driver($driver = null)
         $driver = $driver ?: $this->getDefaultDriver();
 
         if (is_null($driver)) {
-            throw new InvalidArgumentException('Unable to resolve NULL driver for ['.get_class($this).'].');
+            throw new InvalidArgumentException(sprintf(
+                'Unable to resolve NULL driver for [%s].', static::class
+            ));
         }
 
         // If the given driver has not been created before, we will create the instances

src/Illuminate/Support/Traits/Macroable.php

@@ -71,9 +71,9 @@ public static function hasMacro($name)
     public static function __callStatic($method, $parameters)
     {
         if (! static::hasMacro($method)) {
-            $class = static::class;
-
-            throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+            throw new BadMethodCallException(sprintf(
+                'Method %s::%s does not exist.', static::class, $method
+            ));
         }
 
         if (static::$macros[$method] instanceof Closure) {
@@ -95,9 +95,9 @@ public static function __callStatic($method, $parameters)
     public function __call($method, $parameters)
     {
         if (! static::hasMacro($method)) {
-            $class = static::class;
-
-            throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+            throw new BadMethodCallException(sprintf(
+                'Method %s::%s does not exist.', static::class, $method
+            ));
         }
 
         $macro = static::$macros[$method];

src/Illuminate/Validation/Validator.php

@@ -1137,8 +1137,8 @@ public function __call($method, $parameters)
             return $this->callExtension($rule, $parameters);
         }
 
-        $class = static::class;
-
-        throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+        throw new BadMethodCallException(sprintf(
+            'Method %s::%s does not exist.', static::class, $method
+        ));
     }
 }

src/Illuminate/View/Engines/EngineResolver.php

@@ -54,6 +54,6 @@ public function resolve($engine)
             return $this->resolved[$engine] = call_user_func($this->resolvers[$engine]);
         }
 
-        throw new InvalidArgumentException("Engine $engine not found.");
+        throw new InvalidArgumentException("Engine [{$engine}] not found.");
     }
 }

src/Illuminate/View/Factory.php

@@ -276,7 +276,7 @@ public function exists($view)
     public function getEngineFromPath($path)
     {
         if (! $extension = $this->getExtension($path)) {
-            throw new InvalidArgumentException("Unrecognized extension in file: $path");
+            throw new InvalidArgumentException("Unrecognized extension in file: {$path}");
         }
 
         $engine = $this->extensions[$extension];

src/Illuminate/View/FileViewFinder.php

@@ -105,7 +105,7 @@ protected function parseNamespaceSegments($name)
         $segments = explode(static::HINT_PATH_DELIMITER, $name);
 
         if (count($segments) != 2) {
-            throw new InvalidArgumentException("View [$name] has an invalid name.");
+            throw new InvalidArgumentException("View [{$name}] has an invalid name.");
         }
 
         if (! isset($this->hints[$segments[0]])) {
@@ -134,7 +134,7 @@ protected function findInPaths($name, $paths)
             }
         }
 
-        throw new InvalidArgumentException("View [$name] not found.");
+        throw new InvalidArgumentException("View [{$name}] not found.");
     }
 
     /**

src/Illuminate/View/View.php

@@ -396,9 +396,9 @@ public function __unset($key)
     public function __call($method, $parameters)
     {
         if (! Str::startsWith($method, 'with')) {
-            $class = static::class;
-
-            throw new BadMethodCallException("Method {$class}::{$method} does not exist.");
+            throw new BadMethodCallException(sprintf(
+                'Method %s::%s does not exist.', static::class, $method
+            ));
         }
 
         return $this->with(Str::camel(substr($method, 4)), $parameters[0]);