accept dot notation in session::exists (#22935)

laravel · Jan 29, 2018 · 862bb83 · 862bb83
1 parent c89439e
commit 862bb83
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/Illuminate/Session/Store.php b/src/Illuminate/Session/Store.php
@@ -3,6 +3,7 @@
 namespace Illuminate\Session;
 
 use Closure;
+use stdClass;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Str;
 use SessionHandlerInterface;
@@ -174,8 +175,10 @@ public function all()
      */
     public function exists($key)
     {
-        return ! collect(is_array($key) ? $key : func_get_args())->contains(function ($key) {
-            return ! Arr::exists($this->attributes, $key);
+        $placeholder = new stdClass();
+
+        return ! collect(is_array($key) ? $key : func_get_args())->contains(function ($key) use ($placeholder) {
+            return $this->get($key, $placeholder) === $placeholder;
         });
     }
 

diff --git a/tests/Session/SessionStoreTest.php b/tests/Session/SessionStoreTest.php
@@ -324,11 +324,14 @@ public function testKeyExists()
         $session->put('foo', 'bar');
         $this->assertTrue($session->exists('foo'));
         $session->put('baz', null);
+        $session->put('hulk', ['one' => true]);
         $this->assertFalse($session->has('baz'));
         $this->assertTrue($session->exists('baz'));
         $this->assertFalse($session->exists('bogus'));
         $this->assertTrue($session->exists(['foo', 'baz']));
         $this->assertFalse($session->exists(['foo', 'baz', 'bogus']));
+        $this->assertTrue($session->exists(['hulk.one']));
+        $this->assertFalse($session->exists(['hulk.two']));
     }
 
     public function testRememberMethodCallsPutAndReturnsDefault()