-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixed terminable middlewares assigned to the controller
- Loading branch information
1 parent
2bf0851
commit 84eb430
Showing
2 changed files
with
13 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84eb430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to get some more background on this and the reason for this change.
Our application had been built on the assumption that the Middleware is run BEFORE the controller is constructed as in some places the constructors are dependant on data set in the middleware. As such upgrading broke our application.
I am able to get round this by extending this class and reverting the changes but wondering if you can shed a bit more light on what the reason behind this was so we can foresee any problems our way of working may cause.